Re: [PATCH] stable-fixup: hotplug: fix unused function warning

From: Greg Kroah-Hartman
Date: Mon Jan 09 2017 - 06:38:21 EST


On Mon, Jan 09, 2017 at 11:47:50AM +0100, Arnd Bergmann wrote:
> The backport of upstream commit 777c6e0daebb ("hotplug: Make
> register and unregister notifier API symmetric") to linux-4.4.y
> introduced a harmless warning in 'allnoconfig' builds as spotted by
> kernelci.org:
>
> kernel/cpu.c:226:13: warning: 'cpu_notify_nofail' defined but not used [-Wunused-function]
>
> So far, this is the only stable tree that is affected, as linux-4.6 and
> higher contain commit 984581728eb4 ("cpu/hotplug: Split out cpu down functions")
> that makes the function used in all configurations, while older longterm
> releases so far don't seem to have a backport of 777c6e0daebb.
>
> The fix for the warning is trivial: move the unused function back
> into the #ifdef section where it was before.
>
> Link: https://kernelci.org/build/id/586fcacb59b514049ef6c3aa/logs/
> Fixes: 1c0f4e0ebb79 ("hotplug: Make register and unregister notifier API symmetric") in v4.4.y
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> kernel/cpu.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)

Thanks for this, now applied.

greg k-h