Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for Quark
From: Jan Kiszka
Date: Mon Jan 09 2017 - 12:11:22 EST
On 2017-01-05 22:56, Andy Shevchenko wrote:
> On Thu, Jan 5, 2017 at 1:56 AM, Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
>> On Wed, Jan 4, 2017 at 10:48 PM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>>> MSI needs it as well.
>>>
>>> Should have no practical impact, though, as DMA is always available on
>>> the Quark. But given the few users of pci_alloc_irq_vectors so far, this
>>> incorrect pattern may spread otherwise.
>>
>> This looks valid, but let me review it later, need some sleep.
>>
>
> Ah, Jan, perhaps you would like to comment on this one as well
> http://marc.info/?l=linux-serial&m=148334902916347&w=2
>
> ?
>
http://marc.info/?l=linux-serial&m=148334905916354&w=2 enables MSI, but
that's only for Denverton, and there it is unconditional. So this is ok.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux