Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

From: Bryant G. Ly
Date: Mon Jan 09 2017 - 12:23:36 EST


On 1/9/17 10:47 AM, Greg KH wrote:

On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote:
From: "Bryant G. Ly" <bgly@xxxxxxxxxx>

If srp_transfer_data fails within ibmvscsis_write_pending, then
the most likely scenario is that the client timed out the op and
removed the TCE mapping. Thus it will loop forever retrying the
op that is pretty much guaranteed to fail forever. A better return
code would be EIO instead of EAGAIN.

Cc: stable@xxxxxxxxxxxxxxx
Reported-by: Steven Royer <seroyer@xxxxxxxxxxxxxxxxxx>
Tested-by: Steven Royer <seroyer@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Bryant G. Ly <bgly@xxxxxxxxxx>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Why are you sending this to me?

confused,

greg k-h
Sorry I meant to put --to target-devel@xxxxxxxxxxxxxxx, and just --cc you.

-Bryant