Re: [PATCH] of: remove redundant memset in overlay

From: Frank Rowand
Date: Mon Jan 09 2017 - 13:51:53 EST


Hi Rob,

On 01/07/17 03:04, YiPing Xu wrote:
> From: XuYing <xuyiping@xxxxxxxxxxxxx>
>
> memset in of_build_overlay_info is redundant, the ovinfo has been
> zeroed in of_fill_overlay_info when error.
>
> Signed-off-by: YiPing Xu <xuyiping@xxxxxxxxxxxxx>
> ---
> drivers/of/overlay.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index 0d4cda7..4b1b6b3 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -314,7 +314,6 @@ static int of_build_overlay_info(struct of_overlay *ov,
>
> cnt = 0;
> for_each_child_of_node(tree, node) {
> - memset(&ovinfo[cnt], 0, sizeof(*ovinfo));
> err = of_fill_overlay_info(ov, node, &ovinfo[cnt]);
> if (err == 0)
> cnt++;
>

Reviewed-by: Frank Rowand <frank.rowand@xxxxxxxxxxx>

I am in the midst of a cleanup of overlay.c. I can add this patch to
my series if you would prefer. And of course if I get delayed with
the series I would expect you to apply this one without my series if
you desire.

-Frank