Re: [PATCH net v2 5/5] net: qcom/emac: fix of_node and phydev leaks

From: Timur Tabi
Date: Mon Jan 09 2017 - 14:50:00 EST


On 11/24/2016 12:21 PM, Johan Hovold wrote:
+ if (!has_acpi_companion(&pdev->dev))
+ put_device(&adpt->phydev->mdio.dev);

I was wondering if, instead of calling put_device() only on non-ACPI systems, would it be better if on an ACPI system I called get_device() manually? That is, some thing like this:

int emac_phy_config(struct platform_device *pdev, struct emac_adapter *adpt)
{
...
if (has_acpi_companion(&pdev->dev)) {
...
get_device(&mii_bus->dev);
} else {
...

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.