Re: [PATCH V5 09/17] blk-throttle: detect completed idle cgroup

From: Tejun Heo
Date: Mon Jan 09 2017 - 15:13:19 EST


Hello,

On Thu, Dec 15, 2016 at 12:33:00PM -0800, Shaohua Li wrote:
> @@ -1660,6 +1671,11 @@ static bool throtl_tg_can_downgrade(struct throtl_grp *tg)
> struct throtl_data *td = tg->td;
> unsigned long now = jiffies;
>
> + if (time_after_eq(now, tg->last_dispatch_time[READ] +
> + td->throtl_slice) &&
> + time_after_eq(now, tg->last_dispatch_time[WRITE] +
> + td->throtl_slice))
> + return false;

So, the duration used here is gonna be made explicitly configurable by
a future patch, right? Might be worthwhile to note that in the
description.

Thanks.

--
tejun