Re: [PATCH] tmpfs: clear S_ISGID when setting posix ACLs

From: Al Viro
Date: Tue Jan 10 2017 - 03:12:14 EST


On Tue, Jan 10, 2017 at 09:03:01AM +0100, Jan Kara wrote:
> On Mon 09-01-17 09:34:48, Gu Zheng wrote:
> > This change was missed the tmpfs modification in In CVE-2016-7097
> > commit 073931017b49 ("posix_acl: Clear SGID bit when setting
> > file permissions")
> > It can test by xfstest generic/375, which failed to clear
> > setgid bit in the following test case on tmpfs:
> >
> > touch $testfile
> > chown 100:100 $testfile
> > chmod 2755 $testfile
> > _runas -u 100 -g 101 -- setfacl -m u::rwx,g::rwx,o::rwx $testfile
> >
> > Signed-off-by: Gu Zheng <guzheng1@xxxxxxxxxx>
>
> Thanks. The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
> Al, will you please merge it? Thanks!

Already applied, actually...