Re: [PATCH 1/8] mmc-core: Use kmalloc_array() in mmc_test_area_init()

[Shawn Lin]

On 2017/1/9 5:42, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Sun, 8 Jan 2017 18:44:26 +0100
>
> * A multiplication for the size determination of a memory allocation
>   indicated that an array data structure should be processed.
>   Thus use the corresponding function "kmalloc_array".
>
>   This issue was detected by using the Coccinelle software.

Reviewed-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>

> * Replace the specification of a data structure by a pointer dereference
>   to make the corresponding size determination a bit safer according to
>   the Linux coding style convention.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/mmc/core/mmc_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c
> index 3ab6e52d106c..e85ef503d7ce 100644
> --- a/drivers/mmc/core/mmc_test.c
> +++ b/drivers/mmc/core/mmc_test.c
> @@ -1579,7 +1579,7 @@ static int mmc_test_area_init(struct mmc_test_card *test, int erase, int fill)
>  	if (!t->mem)
>  		return -ENOMEM;
>
> -	t->sg = kmalloc(sizeof(struct scatterlist) * t->max_segs, GFP_KERNEL);
> +	t->sg = kmalloc_array(t->max_segs, sizeof(*t->sg), GFP_KERNEL);
>  	if (!t->sg) {
>  		ret = -ENOMEM;
>  		goto out_free;


--
Best Regards
Shawn Lin