Re: [PATCH 08/12] misc: Flexcard misc device support

[Greg Kroah-Hartman]

On Wed, Dec 14, 2016 at 10:28:25AM +0100, Holger Dengler wrote:
> On 12/14/2016 09:42 AM, Arnd Bergmann wrote:
> > On Wednesday, December 14, 2016 1:11:49 AM CET Holger Dengler wrote:
> >> The Flexcard PCI BAR0 contain registers for configuration but also
> >> for informational purpose like error counter, statistical information
> >> and some timestamps. The read-only mmap of the misc device offers the
> >> userspace a fast access to these registers.
> >>
> >> Signed-off-by: Benedikt Spranger <b.spranger@xxxxxxxxxxxxx>
> >> Signed-off-by: Holger Dengler <dengler@xxxxxxxxxxxxx>
> >> cc: Arnd Bergmann <arnd@xxxxxxxx>
> >> cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >> ---
> >>  drivers/mfd/Kconfig          |   1 +
> >>  drivers/misc/Kconfig         |   6 ++
> >>  drivers/misc/Makefile        |   1 +
> >>  drivers/misc/flexcard_misc.c | 165 +++++++++++++++++++++++++++++++++++++++++++
> >>  4 files changed, 173 insertions(+)
> >>  create mode 100644 drivers/misc/flexcard_misc.c
> >>
> > 
> > Maybe this could fit better in drivers/uio/ than drivers/misc? It
> > seems to only export a memory mapped device.
> 
> You're right, this patch only introduce the memory mapping. But the
> next patch in series add also some attributes to the device, therfore
> we put it in drivers/misc. 

That's fine, it should still be a uio driver as that's what it does.
You can have sysfs files for a UIO device, right?

thanks,

greg k-h