Re: [PATCH v2 3/3] arm64: dts: exynos: Remove unneeded unit names in Exynos5433 nodes

[Javier Martinez Canillas]

Hello Krzysztof,

On 01/10/2017 03:51 PM, Krzysztof Kozlowski wrote:

[snip]

>>  
>> -		usbdrd30: usb@15400000  {
>> +		usbdrd30: usb-0  {
> 
> How about "usbdrd" instead of "usb-0"? It would be still quite a generic
> description of a class.
> 
>>  			compatible = "samsung,exynos5250-dwusb3";
>>  			clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
>>  				<&cmu_fsys CLK_SCLK_USBDRD30>;
>> @@ -1332,7 +1332,7 @@
>>  			status = "disabled";
>>  		};
>>  
>> -		usbhost30: usb@15a00000 {
>> +		usbhost30: usb-1 {
> 
> usbhost?
> 

Indeed, these sounds better so I'll change for them.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America