Re: [PATCH 0/2] sched: Introduce rcuwait

From: Davidlohr Bueso
Date: Tue Jan 10 2017 - 14:38:44 EST


On Tue, 10 Jan 2017, Oleg Nesterov wrote:

Well, speaking of naming, rcuwait_trywake() doesn't look good to me,
rcuwait_wake_up() looks better, "try" is misleading imo. But this is
cosmetic/subjective too.

I actually added the 'try' on second thought -- in that for the particular
pcpu-rwsem user, obviously most of the time the wakeup will not actually
occur. But yeah, I'd have no problem just naming it rcuwait_wake_up().

Reviewed-by: Oleg Nesterov <oleg@xxxxxxxxxx>

Thanks!