Re: [PATCH] platform/x86: shut up unused-function warning

From: Arnd Bergmann
Date: Tue Jan 10 2017 - 16:39:56 EST


On Tuesday, January 10, 2017 12:41:17 PM CET Darren Hart wrote:
>
> Thanks Arnd,
>
> This appears to be the preferred approach from coding-style.rst 20) Conditional
> Compilation - we have some cleanup to do in this area I guess.
>
> Queued to next, thanks.

Thanks!

No need to do mass-conversions to __maybe_unused though,
Kirtika Ruchandani has started working on a way for the suspend/resume
functions to automatically get silently discarded when they are
unused, without having an #ifdef or __maybe_unused annotation.

For new code, using __maybe_unused helps avoid this bug though,
and the conversion to the future macros would be easy enough.

Arnd