Re: Dell XPS13 does not suspend with Linux 4.10-rc3

[Jan Niehusmann]

On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
> FW"

Indeed, just disabling the FIXUP implemented by that commit fixes
suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.

(For the addressees newly added to cc, it seems like the mentioned
commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)

--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -406,3 +406,3 @@ static struct mei_fixup {
        MEI_FIXUP(MEI_UUID_WD, mei_wd),
-       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
+//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
 };


I don't know what this may break, as the description of 7279b23 just
says:
"This workaround was added to support other broken OS and we need to
follow here."

Unless there is a better justification, I think the commit should be
reverted, for now.

Jan