Re: [PATCH 1/3 v4] rtc: imxdi: use the security violation interrupt

[Alexandre Belloni]

On 03/01/2017 at 19:49:50 +0100, Martin Kaiser wrote :
> The DryIce chipset has a dedicated security violation interrupt that is
> triggered for security violations (if configured to do so).  According
> to the publicly available imx258 reference manual, irq 56 is used for
> this interrupt.
> 
> If an irq number is provided for the security violation interrupt,
> install the same handler that we're already using for the "normal"
> interrupt.
> 
> imxdi->irq is used only in the probe function, make it a local variable.
> 
> Signed-off-by: Martin Kaiser <martin@xxxxxxxxx>
> ---
> v4:
>   - separate patches for imx25.dtsi and documentation of the new dt binding
> 
> v3:
>   - add the device tree changes to this patch series
>   - install the same interrupt handler for normal and sec irq, rename
>     the handler function accordingly
>   - make imxdi->irq and imxdi->sec_irq local variables in the probe
>     function
> 
> v2:
>   - make sec_irq optional to avoid breaking the Device Tree ABI
>   - removed the Device Tree bindings, I'll prepare a separate patch for them
> 
> 
>  drivers/rtc/rtc-imxdi.c |   28 ++++++++++++++++++++--------
>  1 file changed, 20 insertions(+), 8 deletions(-)
> 
Applied after fixing the multiline comment, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com