Re: [PATCH] scsi: remove useless acpi functions in the head file

[Aaron Lu]

On 01/11/2017 10:15 AM, Hanjun Guo wrote:
> On 2017/1/11 9:50, Aaron Lu wrote:
>> On 01/10/2017 07:44 PM, John Garry wrote:
>>> On 10/01/2017 08:14, Hanjun Guo wrote:
>>>> From: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
>>>>
>>>> commit f1bc1e4c44b1 ("ata: acpi: rework the ata acpi bind support")
>>>> removed scsi_register_acpi_bus_type() and scsi_unregister_acpi_bus_type(),
>>>> but forgot to remove them in the head file, do it now.
>>>>
>>>> Signed-off-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
>> Reviewed-by: Aaron Lu <aaron.lu@xxxxxxxxx>
>>
>> Just out of curiosity, did you find this by some tool? If so, can you
>> please let me know the tool name so that I can avoid such problems in
>> the future? Thanks.
> 
> No, not found by tool. I was working on a patch set which tried to
> introduce a new acpi bus type [1], so I greped the usage of
> "struct acpi_bus_type" then found this issue :)

I see, thanks for the cleanup.

Regards,
Aaron