Re: [PATCH 56/62] watchdog: tangox_wdt: Convert to use device managed functions

[Guenter Roeck]

On 01/11/2017 01:07 AM, Marc Gonzalez wrote:

> > @@ -134,12 +134,15 @@ static int tangox_wdt_probe(struct platform_device *pdev)
> >  	err = clk_prepare_enable(dev->clk);
> >  	if (err)
> >  		return err;
> > +	err = devm_add_action_or_reset(&pdev->dev,
> > +				       (void(*)(void *))clk_disable_unprepare,
> > +				       dev->clk);
> > +	if (err)
> > +		return err;
>
> Hello Guenter,
>
> I would rather avoid the function pointer cast.
> How about defining an auxiliary function for the cleanup action?
>
> clk_disable_unprepare() is static inline, so gcc will have to
> define an auxiliary function either way. What do you think?

Not really. It would just make it more complicated to replace the
call with devm_clk_prepare_enable(), should it ever find its way
into the light of day.

Guenter