Re: [PATCH] tools: gpio add .gitignore for generated files

[Linus Walleij]

On Tue, Jan 10, 2017 at 3:07 PM, Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
> On 01/10/2017 02:29 AM, Linus Walleij wrote:
>> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> wrote:
>>
>>> Add .gitignore for generated files.
>>>
>>> Signed-off-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
>>> ---
>>>  tools/gpio/.gitignore | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>  create mode 100644 tools/gpio/.gitignore
>>>
>>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>>> new file mode 100644
>>> index 0000000..767ad24
>>> --- /dev/null
>>> +++ b/tools/gpio/.gitignore
>>> @@ -0,0 +1,4 @@
>>> +gpio-event-mon
>>> +gpio-hammer
>>> +lsgpio
>>> +include
>>
>> I understand the first three.
>>
>> But "include"?
>> How did you produce that?
>>
>> Yours,
>> Linus Walleij
>>
>
> I saw this after building selftests. gpio selftests Makefile installs
> headres. "make kselftest" should reproduce the problem. This following
> does an header install from tools/testing/selftests/gpio/Makefile
>
> ../../../../usr/include/linux/gpio.h:
>         make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/

That seems like a bug.

I applied the patch removing the ignore line for include,
I think we should see this until we figured out what we do wrong.

Yours,
Linus Walleij