Re: [PATCH 1/5] perf, tools: Add probing for xed

[Jiri Olsa]

On Tue, Jan 10, 2017 at 07:11:50AM +0100, Willy Tarreau wrote:
> Hi Andi,
> 
> just a very minor cosmetic detail, but your editor seems to use tabs while
> there were 8 spaces around, causing visual alignment defects below :
> 
> On Mon, Jan 09, 2017 at 05:02:21PM -0800, Andi Kleen wrote:
> > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> > index e3fb5ecbdcb6..971a9ef87ca6 100644
> > --- a/tools/build/Makefile.feature
> > +++ b/tools/build/Makefile.feature
> > @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC :=                  \
> >          lzma                            \
> >          get_cpuid                       \
> >          bpf                             \
> > -        sdt
> > +	sdt				\
> 
> here
> 
> >  # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list
> >  # of all feature tests
> > @@ -74,11 +74,12 @@ FEATURE_TESTS_EXTRA :=                  \
> >           cplus-demangle                 \
> >           hello                          \
> >           libbabeltrace                  \
> > +	 xed				\
> 
> here
> 
> >           liberty                        \
> >           liberty-z                      \
> >           libunwind-debug-frame          \
> >           libunwind-debug-frame-arm      \
> > -         libunwind-debug-frame-aarch64
> > +	 libunwind-debug-frame-aarch64
> 
> here
> 
> >  
> >  FEATURE_TESTS ?= $(FEATURE_TESTS_BASIC)
> >  
> > @@ -105,7 +106,7 @@ FEATURE_DISPLAY ?=              \
> >           zlib                   \
> >           lzma                   \
> >           get_cpuid              \
> > -         bpf
> > +	 bpf
> 
> and here.
> 
> I think it would be nice to fix them before merging.
> 
> Did I say it was very minor ? :-)

yea, but still.. ;-)

jirka