Re: [PATCHv3] HID: i2c-hid: Add sleep between POWER ON and RESET

From: Jiri Kosina
Date: Wed Jan 11 2017 - 15:56:09 EST


On Sat, 7 Jan 2017, Brendan McGrath wrote:

> Support for the Asus Touchpad was recently added. It turns out this
> device can fail initialisation (and become unusable) when the RESET
> command is sent too soon after the POWER ON command.
>
> Unfortunately the i2c-hid specification does not specify the need for
> a delay between these two commands. But it was discovered the Windows
> driver has a 1ms delay.
>
> As a result, this patch modifies the i2c-hid module to add a sleep
> inbetween the POWER ON and RESET commands which lasts between 1ms and 5ms.
>
> See https://github.com/vlasenko/hid-asus-dkms/issues/24 for further
> details.
>
> Signed-off-by: Brendan McGrath <redmcg@xxxxxxxxxxxxxxxxxxx>
> ---
> Changes since v2:
> - added comments to explain the reason for the sleep

Applied to for-4.10/upstream-fixes, thanks.

--
Jiri Kosina
SUSE Labs