Re: [PATCH 44/62] watchdog: pnx4008_wdt: Convert to use device managed functions

[Vladimir Zapolskiy]

Hi Guenter,

On 01/11/2017 02:44 AM, Guenter Roeck wrote:
> Use device managed functions to simplify error handling, reduce
> source code size, improve readability, and reduce the likelyhood of bugs.
> 
> The conversion was done automatically with coccinelle using the
> following semantic patches. The semantic patches and the scripts used
> to generate this commit log are available at
> https://github.com/groeck/coccinelle-patches
> 
> - Use devm_add_action_or_reset() for calls to clk_disable_unprepare
> - Replace 'goto l; ... l: return e;' with 'return e;'
> - Drop remove function
> - Use devm_watchdog_register_driver() to register watchdog device
> 
> Cc: Vladimir Zapolskiy <vz@xxxxxxxxx>

Acked-by: Vladimir Zapolskiy <vz@xxxxxxxxx>

Thank you for the cleanup.

> Cc: Sylvain Lemieux <slemieux.tyco@xxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

--
With best wishes,
Vladimir