Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants

From: Dan Williams
Date: Thu Jan 12 2017 - 12:01:41 EST


On Thu, Jan 12, 2017 at 7:37 AM, Michal Hocko <mhocko@xxxxxxxxxx> wrote:
> From: Michal Hocko <mhocko@xxxxxxxx>
>
> There are many code paths opencoding kvmalloc. Let's use the helper
> instead. The main difference to kvmalloc is that those users are usually
> not considering all the aspects of the memory allocator. E.g. allocation
> requests < 64kB are basically never failing and invoke OOM killer to
> satisfy the allocation. This sounds too disruptive for something that
> has a reasonable fallback - the vmalloc. On the other hand those
> requests might fallback to vmalloc even when the memory allocator would
> succeed after several more reclaim/compaction attempts previously. There
> is no guarantee something like that happens though.
>
> This patch converts many of those places to kv[mz]alloc* helpers because
> they are more conservative.
>
[..]
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
[..]
> drivers/nvdimm/dimm_devs.c | 5 +---

Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>