Re: [PATCH 2/5] clk: sunxi-ng: add support for V3s CCU

[Maxime Ripard]

On Fri, Jan 13, 2017 at 01:31:41AM +0800, Icenowy Zheng wrote:
> 
> 2017å1æ13æ 01:19ä Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>åéï
> >
> > On Thu, Jan 12, 2017 at 03:44:53AM +0800, Icenowy Zheng wrote: 
> > > 
> > > 
> > > 12.01.2017, 03:40, "Icenowy Zheng" <icenowy@xxxxxxxx>: 
> > > > 11.01.2017, 02:10, "Maxime Ripard" <maxime.ripard@xxxxxxxxxxxxxxxxxx>: 
> > > >> ÂOn Tue, Jan 03, 2017 at 11:16:26PM +0800, Icenowy Zheng wrote: 
> > > >>> ÂÂV3s has a similar but cut-down CCU to H3. 
> > > >>> 
> > > >>> ÂÂAdd support for it. 
> > > >>> 
> > > >>> ÂÂSigned-off-by: Icenowy Zheng <icenowy@xxxxxxxx> 
> > > >> 
> > > >> ÂIt looks like there's nothing different but the clocks that you 
> > > >> Âregister with the H3, please just use the H3 driver. 
> > > > 
> > > > Nope. 
> > > > 
> > > > It has a different PLL (PLL_ISP) at different address, and some 
> > > > different muxes. 
> > > 
> > > Forgot to mention the missing of PLL_DE and related misses. 
> >
> > Those are not conflicting, it's just a slightly different set of 
> > clocks. 
> 
> If saying so, we can have only one ccu driver, and make every ccu
> register different set ;-)
> 
> V3s itself is a totally different SoC with H3.
> 
> The relationship of V3s and H3 can be farther than the relationship
> of A33 and H3ð

A33 and H3 are an entirely different story. The H3 and A33 have
conflicting clocks (ie same clocks with different parameters). This is
not your case.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature