Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

From: David Miller
Date: Thu Jan 12 2017 - 16:59:26 EST


From: Shannon Nelson <shannon.nelson@xxxxxxxxxx>
Date: Thu, 12 Jan 2017 13:58:10 -0800

>
>
> On 1/12/2017 1:47 PM, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@xxxxxxxxx>
>> Date: Thu, 12 Jan 2017 13:36:30 -0800
>>
>>> val should be an union, so that proper alignment is enforced by one
>>> member.
>>
>> Sure, annotating the type so that it is aligned correctly makes
>> sense.
>>
>
> ... and we should change the offending pointer assignment as well. I
> can use this and respin a v2 if we're happy with this solution.

I am.