Re: [PATCH v2] tcp: fix tcp_fastopen unaligned access complaints on sparc

[Eric Dumazet]

On Thu, 2017-01-12 at 14:24 -0800, Shannon Nelson wrote:
> Fix up a data alignment issue on sparc by swapping the order
> of the cookie byte array field with the length field in
> struct tcp_fastopen_cookie, and making it a proper union
> to clean up the typecasting.
> 
> This addresses log complaints like these:
>     log_unaligned: 113 callbacks suppressed
>     Kernel unaligned access at TPC[976490] tcp_try_fastopen+0x2d0/0x360
>     Kernel unaligned access at TPC[9764ac] tcp_try_fastopen+0x2ec/0x360
>     Kernel unaligned access at TPC[9764c8] tcp_try_fastopen+0x308/0x360
>     Kernel unaligned access at TPC[9764e4] tcp_try_fastopen+0x324/0x360
>     Kernel unaligned access at TPC[976490] tcp_try_fastopen+0x2d0/0x360
> 
> Cc: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> Signed-off-by: Shannon Nelson <shannon.nelson@xxxxxxxxxx>
> ---
> v2: Use Eric's suggestion for a union in the struct

Acked-by: Eric Dumazet <edumazet@xxxxxxxxxx>

Thanks for fixing this !