Re: [PATCH 4.9 003/116] rtlwifi: Fix enter/exit power_save

[Greg Kroah-Hartman]

On Fri, Jan 13, 2017 at 08:42:03AM +0200, Kalle Valo wrote:
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes:
> 
> > On Tue, Jan 10, 2017 at 10:51:56PM +0100, Willy Tarreau wrote:
> >> On Tue, Jan 10, 2017 at 03:23:27PM -0600, lkml@xxxxxxxxxxx wrote:
> >> > On Tue, Jan 10, 2017 at 09:40:24PM +0100, Greg Kroah-Hartman wrote:
> >> > > On Tue, Jan 10, 2017 at 08:40:28PM +0300, Dmitry Osipenko wrote:
> >> > > > Hello, this patch causes a kernel panic with the rtl8192cu driver.
> >> > > 
> >> > > Ick, not good!  Does this cause a problem in Linus's tree as well?
> >> > > 
> >> > 
> >> > http://lkml.iu.edu/hypermail/linux/kernel/1701.1/00228.html
> >> 
> >> OK the pending patch is here and not yet upstream :
> >> 
> >>     http://marc.info/?l=linux-wireless&m=148234081512703&w=2
> >> 
> >> It fixes ba9f93f82aba (patch 3/116) so better postpone it until
> >> the patch above gets merged.
> >
> > Yes, I've reverted this now and will wait for this fixup to hit Linus's
> > tree.  Larry, can you remind me to include the original patch in the
> > stable tree when this fixup is merged?
> 
> Linus pulled it now:
> 
> commit 60f59ce0278557f7896d5158ae6d12a4855a72cc
> Author: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> Date:   Wed Dec 21 11:18:55 2016 -0600
> 
>     rtlwifi: rtl_usb: Fix missing entry in USB driver's private data
>     
>     These drivers need to be able to reference "struct ieee80211_hw"
>     from
>     the driver's private data, and vice versa. The USB driver failed to
>     store the address of ieee80211_hw in the private data. Although this
>     bug has been present for a long time, it was not exposed until
>     commit ba9f93f82aba ("rtlwifi: Fix enter/exit power_save").
>     
>     Fixes: ba9f93f82aba ("rtlwifi: Fix enter/exit power_save")
>     Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
>     Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>

Thanks will queue these two up now.

greg k-h