Re: [PATCH 16/37] PCI: endpoint: Introduce configfs entry for configuring EP functions
From: Christoph Hellwig
Date: Fri Jan 13 2017 - 13:07:18 EST
Hi Kishon,
a couple comments on the configfs layout based on my experiments with
your previous drop to implement a NVMe device using it.
I don't think most of these configfs files should be present here, as
they are properties of the implemented PCIe devices. E.g. for my
NVMe device they will be sort of hardcoded most of the time, as they
would be for other devices that would always have a fixed vendor/device/
class ID, cacheline size, etc.
In the end what we'll to be able to do here is to be able to create
a directory for each function driver, which then can create it's own
attributes inside it.