Re: [PATCH v3] ARM: dts: Add LEGO MINDSTORMS EV3 dts

[David Lechner]

On 01/13/2017 12:16 PM, David Lechner wrote:
> On 01/13/2017 06:04 AM, Sekhar Nori wrote:
> > On Friday 13 January 2017 02:02 AM, David Lechner wrote:
> > > This adds a device tree definition file for LEGO MINDSTORMS EV3.
> ...
> > There are couple of checkpatch errors that show up. The compatible
> > "lego,ev3" needs to be documented in
> > Documentation/devicetree/bindings/arm/davinci.txt
> >
> > "at24,24c128" is undocumented. Is that an atmel chip on the EV3? If the
> > manufacturer name is not clear,
> > Documentation/devicetree/bindings/eeprom/eeprom.txt advises using just
> > "24c128"
>
> The mfg is microchip, so I guess I will just go with "24c128"

I think I have let the device tree bindings doc confuse me. On second 
though, I think the correct thing is to included the manufacturer.

> > Finally, lego needs to be added to
> > Documentation/devicetree/bindings/vendor-prefixes.txt
> >
> > Can you please submit the documentation portions as separate patches in
> > a series along with this patch.
>
> Yes.
>
> > Thanks,
> > Sekhar