Re: [PATCH 2/6] mm: support __GFP_REPEAT in kvmalloc_node for >=64kB

[Michal Hocko]

On Sat 14-01-17 11:42:09, Tetsuo Handa wrote:
> On 2017/01/13 0:37, Michal Hocko wrote:
[...]
> > diff --git a/mm/util.c b/mm/util.c
> > index 7e0c240b5760..9306244b9f41 100644
> > --- a/mm/util.c
> > +++ b/mm/util.c
> > @@ -333,7 +333,8 @@ EXPORT_SYMBOL(vm_mmap);
> >   * Uses kmalloc to get the memory but if the allocation fails then falls back
> >   * to the vmalloc allocator. Use kvfree for freeing the memory.
> >   *
> > - * Reclaim modifiers - __GFP_NORETRY, __GFP_REPEAT and __GFP_NOFAIL are not supported
> > + * Reclaim modifiers - __GFP_NORETRY and __GFP_NOFAIL are not supported. __GFP_REPEAT
> > + * is supported only for large (>64kB) allocations
> 
> Isn't this ">32kB" (i.e. __GFP_REPEAT is supported for 64kB allocation) ?

True, I will update the patch to use >32kB

Thanks!
-- 
Michal Hocko
SUSE Labs