Re: [PATCH v4 0/5] thermal: fixes the rockchip thermal

From: Eduardo Valentin
Date: Sat Jan 14 2017 - 11:54:56 EST


Folks,

On Wed, Jan 04, 2017 at 12:30:40AM +0800, ayaka wrote:
>
>
> On 01/03/2017 09:13 AM, Randy Li wrote:
> >
> >
> >On 01/03/2017 09:02 AM, Caesar Wang wrote:
> >>
> >>å 2017å01æ03æ 07:57, Randy Li åé:
> >>>
> >>>On 01/02/2017 09:16 PM, Caesar Wang wrote:
> >>>>å 2016å12æ31æ 00:11, ayaka åé:
> >>>>>
> >>>>>BTW, Caesar have you ever met this at RK3288 at booting time?
> >>>>>[ 8.430582] thermal thermal_zone1: critical temperature
> >>>>>reached(125 C),shutting down
> >>>>>[ 8.439038] thermal thermal_zone2: critical temperature
> >>>>>reached(125 C),shutting down
> >>>>>[ 8.456344] thermal thermal_zone1: critical temperature
> >>>>>reached(125 C),shutting down
> >>>>>[ 8.465298] thermal thermal_zone2: critical temperature
> >>>>>reached(125 C),shutting down
> >>>>
> >>>>125C? the thermal zone isn't the upstream kernel, what's the kernel
> >>>>version?
> >>>They have been merged into the linux-next.
> >>
> >>Really?
> >>I saw the 90 degree is the critical temperature on rk3288 dts .
> >Yes I do.
> >>kernel$ vi arch/arm/boot/dts/rk3288.dtsi
> >> cpu_crit: cpu_crit {
> >> temperature = <90000>; /* millicelsius */
> >> hysteresis = <2000>; /* millicelsius */
> >> type = "critical";
> >> };
> >>
> >>>>Anyway, look like, the TSHUT issue. Do you have the below patches
> >>>>for your linux kernel?
> >>>>http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/380446.html
> >>>>
> >>>>
> >>>No, could you resubmit those patches ?
> >>
> >>These patches had merged for upstream.
> >Sorry, it is my fault, I mistake that commit. Those patches are merged in
> >next-20161224. I would bring a board for you later.
> I check the schematic, the otp interrupt is not used at firefly reload nor
> connected to the control of PMIC.
> I also check power supply, the power is PD_PERI domain comes from VD_LOGIC
> which is always on all the platform.
> It more likely the tsadc doesn't report correctly temperature value?

Folks, I got a bit confused about this discussion. I have put these
patches into linux-next, as I did not see anything wrong with them. And
I was about to send to next -rc.

Are these correct or not? Is it fine to move forward with them?

I believe for tomorrows rc is a bit too late, but I think they could
still go to the next rc.

BR,

> >>
> >>-Caesar
> >>
> >>
> >
>