Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"

[Linus Torvalds]

On Sun, Jan 15, 2017 at 8:11 AM, James Bottomley
<James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> We're not reverting a fix that would cause regressions for others.

Oh HELL YES we are.

The rule is that we never break old stuff. Some new fix that fixes
something that never used to work, but breaks something else, gets
reverted very aggressively.

So if a new bugfix or workaround causes problems for existing users,
it gets reverted. The fact that it fixed something else is COMPLETELY
IRRELEVANT.

We do not do the "one step forward, two steps back" dance. If you
can't fix a bug without breaking old systems, the "fix" gets reverted.

Apparently there is already a possible real fix in flight, so I won't
actually do the revert, but I very much want to object to your
statement.

Reverts happen.

            Linus