Re: [PATCH 1/2] spi: pxa2xx: Prepare for edge-triggered interrupts

[Andy Shevchenko]

On Mon, 2017-01-16 at 10:05 +0100, Jan Kiszka wrote:
> When using the a device with edge-triggered interrupts, such as MSIs,
> the interrupt handler has to ensure that there is a point in time
> during
> its execution where all interrupts sources are silent so that a new
> event can trigger a new interrupt again.
> 
> This is achieved here by looping over SSSR evaluation. We need to take
> into account that SSCR1 may be changed by the transfer handler, thus
> we
> need to redo the mask calculation, at least regarding the volatile
> interrupt enable bit (TIE).

Could you split this to two patches, one just move the code under
question to a helper function (no functional change), the other does
what you state in commit message here?

> 
> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
> ---
> Âdrivers/spi/spi-pxa2xx.c | 50 +++++++++++++++++++++++++++----------
> -----------
> Â1 file changed, 28 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
> index dd7b5b4..24bf549 100644
> --- a/drivers/spi/spi-pxa2xx.c
> +++ b/drivers/spi/spi-pxa2xx.c
> @@ -737,6 +737,7 @@ static irqreturn_t ssp_int(int irq, void *dev_id)
> Â	struct driver_data *drv_data = dev_id;
> Â	u32 sccr1_reg;
> Â	u32 mask = drv_data->mask_sr;
> +	irqreturn_t ret = IRQ_NONE;
> Â	u32 status;
> Â
> Â	/*
> @@ -760,37 +761,42 @@ static irqreturn_t ssp_int(int irq, void
> *dev_id)
> Â
> Â	sccr1_reg = pxa2xx_spi_read(drv_data, SSCR1);
> Â
> -	/* Ignore possible writes if we don't need to write */
> -	if (!(sccr1_reg & SSCR1_TIE))
> -		mask &= ~SSSR_TFS;
> -
> Â	/* Ignore RX timeout interrupt if it is disabled */
> Â	if (!(sccr1_reg & SSCR1_TINTE))
> Â		mask &= ~SSSR_TINT;
> Â
> -	if (!(status & mask))
> -		return IRQ_NONE;
> +	while (1) {
> +		/* Ignore possible writes if we don't need to write
> */
> +		if (!(sccr1_reg & SSCR1_TIE))
> +			mask &= ~SSSR_TFS;
> Â
> -	if (!drv_data->master->cur_msg) {
> +		if (!(status & mask))
> +			return ret;
> Â
> -		pxa2xx_spi_write(drv_data, SSCR0,
> -				Âpxa2xx_spi_read(drv_data, SSCR0)
> -				Â& ~SSCR0_SSE);
> -		pxa2xx_spi_write(drv_data, SSCR1,
> -				Âpxa2xx_spi_read(drv_data, SSCR1)
> -				Â& ~drv_data->int_cr1);
> -		if (!pxa25x_ssp_comp(drv_data))
> -			pxa2xx_spi_write(drv_data, SSTO, 0);
> -		write_SSSR_CS(drv_data, drv_data->clear_sr);
> +		if (!drv_data->master->cur_msg) {
> Â
> -		dev_err(&drv_data->pdev->dev,
> -			"bad message state in interrupt handler\n");
> +			pxa2xx_spi_write(drv_data, SSCR0,
> +					Âpxa2xx_spi_read(drv_data,
> SSCR0)
> +					Â& ~SSCR0_SSE);
> +			pxa2xx_spi_write(drv_data, SSCR1,
> +					Âpxa2xx_spi_read(drv_data,
> SSCR1)
> +					Â& ~drv_data->int_cr1);
> +			if (!pxa25x_ssp_comp(drv_data))
> +				pxa2xx_spi_write(drv_data, SSTO, 0);
> +			write_SSSR_CS(drv_data, drv_data->clear_sr);
> Â
> -		/* Never fail */
> -		return IRQ_HANDLED;
> -	}
> +			dev_err(&drv_data->pdev->dev,
> +				"bad message state in interrupt
> handler\n");
> Â
> -	return drv_data->transfer_handler(drv_data);
> +			/* Never fail */
> +			return IRQ_HANDLED;
> +		}
> +
> +		ret |= drv_data->transfer_handler(drv_data);
> +
> +		status = pxa2xx_spi_read(drv_data, SSSR);
> +		sccr1_reg = pxa2xx_spi_read(drv_data, SSCR1);
> +	}
> Â}
> Â
> Â/*

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy