Re: [PATCH] xfrm: state: fix potential null pointer dereference on afinfo

From: Steffen Klassert
Date: Mon Jan 16 2017 - 08:27:18 EST


On Fri, Jan 13, 2017 at 02:07:03PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> afinfo is being null checked before a call afinfo->init_tempsel
> so afinfo may be potentially null. ifinfo may still be null in
> the case were it is not updated when family == tmpl->encap_family,
> hence we may hit a null pointer dereference in the call to
> afinfo->init_temprop.
>
> Fix this by adding a null ptr check before calling init_temprop.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

I've applied already a fix for this from Florian Westphal.

Thanks a lot anyway!