Re: [PATCH 1/1] x86/rtc: Allocate interrupt for platform device

[Andy Shevchenko]

On Mon, 2017-01-16 at 22:46 +0800, kbuild test robot wrote:
> Hi Andy,
> 
> [auto build test ERROR on tip/auto-latest]
> [also build test ERROR on v4.10-rc4 next-20170116]
> [if your patch is applied to the wrong git tree, please drop us a note
> to help improve the system]
> 
> url:ÂÂÂÂhttps://github.com/0day-ci/linux/commits/Andy-Shevchenko/x86-r
> tc-Allocate-interrupt-for-platform-device/20170116-222720
> config: x86_64-randconfig-x011-201703 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> ÂÂÂÂÂÂÂÂ# save the attached .config to linux build tree
> ÂÂÂÂÂÂÂÂmake ARCH=x86_64Â
> 
> All errors (new ones prefixed by >>):
> 
> ÂÂÂarch/x86/kernel/rtc.c: In function 'add_rtc_cmos':
> > > arch/x86/kernel/rtc.c:202:2: error: implicit declaration of
> > > function 'ioapic_set_alloc_attr' [-Werror=implicit-function-
> > > declaration]
> 
> ÂÂÂÂÂioapic_set_alloc_attr(&info, NUMA_NO_NODE, 1, 0);
> ÂÂÂÂÂ^~~~~~~~~~~~~~~~~~~~~
> > > arch/x86/kernel/rtc.c:203:8: error: implicit declaration of
> > > function 'mp_map_gsi_to_irq' [-Werror=implicit-function-
> > > declaration]
> 
> ÂÂÂÂÂret = mp_map_gsi_to_irq(RTC_IRQ, IOAPIC_MAP_ALLOC, &info);
> ÂÂÂÂÂÂÂÂÂÂÂ^~~~~~~~~~~~~~~~~
> > > arch/x86/kernel/rtc.c:203:35: error: 'IOAPIC_MAP_ALLOC' undeclared
> > > (first use in this function)
> 
> ÂÂÂÂÂret = mp_map_gsi_to_irq(RTC_IRQ, IOAPIC_MAP_ALLOC, &info);
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ^~~~~~~~~~~~~~~~
> ÂÂÂarch/x86/kernel/rtc.c:203:35: note: each undeclared identifier is
> reported only once for each function it appears in
> ÂÂÂcc1: some warnings being treated as errors

Hmm... Perhaps nice catch. I would check what I have missed, though I
even tested this change on two platforms.

> 
> vim +/ioapic_set_alloc_attr +202 arch/x86/kernel/rtc.c
> 
> ÂÂÂ196			}
> ÂÂÂ197		}
> ÂÂÂ198	#endif
> ÂÂÂ199		if (!x86_platform.legacy.rtc)
> ÂÂÂ200			return -ENODEV;
> ÂÂÂ201	
> Â> 202		ioapic_set_alloc_attr(&info, NUMA_NO_NODE, 1,
> 0);
> Â> 203		ret = mp_map_gsi_to_irq(RTC_IRQ,
> IOAPIC_MAP_ALLOC, &info);
> ÂÂÂ204		if (ret < 0)
> ÂÂÂ205			return ret;
> ÂÂÂ206	
> 
> ---
> 0-DAY kernel test infrastructureÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂOpen Source Technology
> Center
> https://lists.01.org/pipermail/kbuild-allÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂIntel
> Corporation

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy