Re: [PATCH 0/5 v3] adv7511 EDID probing improvements

From: Laurent Pinchart
Date: Mon Jan 16 2017 - 10:56:54 EST


Hi John,

Thank you for the patches.

On Tuesday 03 Jan 2017 11:41:37 John Stultz wrote:
> Hope everyone had a good newyears!
>
> Wanted to re-send out v3 of this patch set improving the EDID
> probing on the adv7511 used on HiKey, for consideration for
> merging for 4.11
>
> The first three patches are fixups that are hopefully straight
> forward, integrating feedback I got from Laurant.
>
> The last two patches try to clean up and resue code, which as
> a side effect avoids an issue I'm seeing where something is
> going wrong with the regmap cache state for the
> ADV7511_REG_EDID_I2C_ADDR(0x43) register which results in
> i2c_transfer errors if we don't do the
> regcache_sync/_mark_dirty() calls. I suspect there might be a
> better solution there, but have not gotten any other suggestions
> so I wanted to go ahead and submit these.
>
> Thoughts and feedback would be appreciated!

For the whole series,

Tested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> New in v3:
> * Addressed naming improvements and drm_kms_helper_hotplug_event
> usage corrections as suggested by Laurent.
>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Archit Taneja <architt@xxxxxxxxxxxxxx>
> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
>
> Archit Taneja (1):
> drm/bridge: adv7511: Enable HPD interrupts to support hotplug and
> improve monitor detection
>
> John Stultz (4):
> drm/bridge: adv7511: Use work_struct to defer hotplug handing to out
> of irq context
> drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event()
> drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be
> reused internally
> drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID
>
> drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 +
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 62
> +++++++++++++++++++--------- 2 files changed, 44 insertions(+), 20
> deletions(-)

--
Regards,

Laurent Pinchart