Re: [PATCH v2 3/3] spi: pca2xx-pci: Allow MSI

[Andy Shevchenko]

On Mon, 2017-01-16 at 19:44 +0100, Jan Kiszka wrote:
> Now that the core is ready for edge-triggered interrupts, we can
> safely
> allow the PCI versions that provide this to enable the feature and,
> thus, have less shared interrupts.
> 

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>



>Âdrivers/spi/spi-pxa2xx-pci.c | 8 +++++++-
> Â1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-
> pci.c
> index 58d2d48..58dcadb 100644
> --- a/drivers/spi/spi-pxa2xx-pci.c
> +++ b/drivers/spi/spi-pxa2xx-pci.c
> @@ -203,10 +203,16 @@ static int pxa2xx_spi_pci_probe(struct pci_dev
> *dev,
> Â	ssp = &spi_pdata.ssp;
> Â	ssp->phys_base = pci_resource_start(dev, 0);
> Â	ssp->mmio_base = pcim_iomap_table(dev)[0];
> -	ssp->irq = dev->irq;
> Â	ssp->port_id = (c->port_id >= 0) ? c->port_id : dev->devfn;
> Â	ssp->type = c->type;
> Â
> +	pci_set_master(dev);
> +
> +	ret = pci_alloc_irq_vectors(dev, 1, 1, PCI_IRQ_ALL_TYPES);
> +	if (ret < 0)
> +		return ret;

+ perhaps an empty line?

> +	ssp->irq = pci_irq_vector(dev, 0);
> +
> Â	snprintf(buf, sizeof(buf), "pxa2xx-spi.%d", ssp->port_id);
> Â	ssp->clk = clk_register_fixed_rate(&dev->dev, buf , NULL, 0,
Â					ÂÂÂc->max_clk_rate);

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy