Re: [PATCH v2] partially revert "xen: Remove event channel notification through Xen PCI platform device"
From: Stefano Stabellini
Date: Mon Jan 16 2017 - 19:46:16 EST
On Mon, 16 Jan 2017, Juergen Gross wrote:
> On 13/01/17 19:44, Boris Ostrovsky wrote:
> > On 01/13/2017 01:26 PM, Stefano Stabellini wrote:
> >> On Fri, 13 Jan 2017, Boris Ostrovsky wrote:
> >>> On 01/12/2017 04:39 PM, Stefano Stabellini wrote:
> >>>> The following commit:
> >>>>
> >>>> commit 72a9b186292d98494f222226cfd24a1621796209
> >>>> Author: KarimAllah Ahmed <karahmed@xxxxxxxxx>
> >>>> Date: Fri Aug 26 23:55:36 2016 +0200
> >>>>
> >>>> xen: Remove event channel notification through Xen PCI platform device
> >>>>
> >>>> broke Linux when booting as Dom0 on Xen in a nested Xen environment (Xen
> >>>> installed inside a Xen VM). In this scenario, Linux is a PV guest, but
> >>>> at the same time it uses the platform-pci driver to receive
> >>>> notifications from L0 Xen. vector callbacks are not available because L1
> >>>> Xen doesn't allow them.
> >>>>
> >>>> Partially revert the offending commit, by restoring IRQ based
> >>>> notifications for PV guests only. I restored only the code which is
> >>>> strictly needed and replaced the xen_have_vector_callback checks within
> >>>> it with xen_pv_domain() checks.
> >>>>
> >>>> Signed-off-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> >>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> >> Applied to xentip/for-linus-4.10, improving the commit message as
> >> suggested before.
> >>
> >> Do you plan on sending out another pull request for 4.10?
> >
> > Juergen?
>
> Originally I didn't plan to, but I'm not opposed to sending out one.
I think that would be best.
Thanks,
Stefano