Re: [RFC PATCH v2 10/10] dt-bindings: Document devicetree binding for ARM SPE
From: Kim Phillips
Date: Tue Jan 17 2017 - 11:31:31 EST
On Mon, 16 Jan 2017 10:59:04 +0000
Will Deacon <will.deacon@xxxxxxx> wrote:
> On Fri, Jan 13, 2017 at 06:43:52PM +0000, Mark Rutland wrote:
> > On Fri, Jan 13, 2017 at 04:03:49PM +0000, Will Deacon wrote:
> > > +- compatible : should be one of:
> > > + "arm,arm-spe-pmu-v1"
> >
> > The second "arm" here doesn't seem to add much. Should that be "armv8.2"
> > instead?
>
> I don't think armv8.2 is particularly helpful, because that effectively ties
> together the SPE version and the architecture version, which I don't think
> is strictly required. The reason I added it was so that you could describe
> a partner implementation as something like:
>
> acme,arm-spe-pmu-v1
>
> and know that it was acme's implementation of an ARM architectural feature.
Wouldn't such an implementation be compatible with an
"arm,arm-spe-pmu-v1" (or one with less "arm"s)?
> If I drop the second "arm", I was worried that it might conflict with other
> namespaces (e.g. acme's signal-processing-element's power-management-unit).
I'd personally let them worry about that, esp. because this problem
would come up first and hopefully be fixed in the marketing domain
before it reaches its device tree specification stage.
Kim