Re: [PATCH 7/8] slab: remove synchronous synchronize_sched() from memcg cache deactivation path

From: Tejun Heo
Date: Tue Jan 17 2017 - 11:50:49 EST


On Tue, Jan 17, 2017 at 09:26:11AM +0900, Joonsoo Kim wrote:
> > + INIT_WORK(&s->memcg_params.deact_work, kmemcg_deactivate_workfn);
> > + schedule_work(&s->memcg_params.deact_work);
> > +}
>
> Isn't it better to submit one work item for each memcg like as
> Vladimir did? Or, could you submit this work to the ordered workqueue?
> I'm not an expert about workqueue like as you, but, I think
> that there is a chance to create a lot of threads if there is
> the slab_mutex lock contention.

Yeah, good point. I'll switch it to its own workqueue w/ concurrency
limited to one.

Thanks.

--
tejun