davinci common clock framework (was Re: [PATCH 03/10] devicetree: bindings: add bindings for ahci-da850)

From: David Lechner
Date: Tue Jan 17 2017 - 13:32:03 EST


On 01/17/2017 06:00 AM, Sekhar Nori wrote:
On Tuesday 17 January 2017 12:17 AM, David Lechner wrote:
On 01/16/2017 08:30 AM, Bartosz Golaszewski wrote:
2017-01-16 13:45 GMT+01:00 Sekhar Nori <nsekhar@xxxxxx>:
On Monday 16 January 2017 03:43 PM, Bartosz Golaszewski wrote:

It's true that once davinci gets ported (is this planned?) to using
the common clock framework, we could just create a fixed-clock node in
da850-lcdk for the SATA oscillator, so the new property is redundant.


I have some commits[1] where I started on converting da850 to use the
common clock framework. But, I don't know anything about other davinci
family devices, so I don't think I could really take that to completion
without lots of help.

I can help with testing, reviewing and filling in any missing
information. But I wont have time to write the code itself.


[1]: https://github.com/dlech/ev3dev-kernel/commits/wip-20160509

I see that you have made a copy of the keystone PSC driver. I think you
will need pretty strong reasons to not use the same driver with some
customization for DaVinci.


It has been a while since I looked at this, but as I recall, the device tree bindings for keystone are horrible and make no sense. So, I made new bindings that make more sense. But since we can't break backwards compatibility in device tree, I made a new driver rather than having the mess of supporting two very different bindings in one driver. I don't know if that is a strong enough reason, but that is why I did it. :-)