Re: [PATCH -next] init/main: Init jump_labels before they are used to build zonelists

[Vlastimil Babka]

On 17.1.2017 21:34, Andrew Morton wrote:
>>>
>>> Will you be able to look into that? Openrisc doesnt have jump_label
>>> support, so its no issue at the moment.
>>>
>>> Archs that do have it:
>>>
>>> arch/arm64/Kconfig:     select HAVE_ARCH_JUMP_LABEL
>>> arch/mips/Kconfig:      select HAVE_ARCH_JUMP_LABEL
>>> arch/s390/Kconfig:      select HAVE_ARCH_JUMP_LABEL
>>> arch/sparc/Kconfig:     select HAVE_ARCH_JUMP_LABEL if SPARC64
>>> arch/tile/Kconfig:      select HAVE_ARCH_JUMP_LABEL
>>> arch/x86/Kconfig:       select HAVE_ARCH_JUMP_LABEL
>>> arch/arm/Kconfig:       select HAVE_ARCH_JUMP_LABEL if !XIP_KERNEL && !CPU_ENDIAN_BE32 && MMU
>>> arch/powerpc/Kconfig:   select HAVE_ARCH_JUMP_LABEL
>>>
>>> I looked at a few (arm, tile) and I dont see their arch_jump_label_transform*
>>> implementations depending on global state like ideal_nops from x86. They
>>> should be ok.
>>
>> Thanks, I'll try.
>>
>>> If no time, Should you change your patch to not use static keys for
>>> build_all_zonelists at least?
>>
>> Yes that would be uglier but possible if I find issues or I'm not
>> confident enough with the auditing...
> 
> We could just revert f5adbdff6a1c40e19 ("mm, page_alloc: convert
> page_group_by_mobility_disable to static key")?

That's a -next commit id, as the patch is in mmotm. I'll ask for removal if I
don't have a fix soon, but if you or somebody else prefers to do that ASAP, it
can be re-added later with a fix.