Re: [PATCH] x86/ioapic: add IO-APIC irq_chip retrigger hook

[Thomas Gleixner]

On Tue, 17 Jan 2017, Ruslan Ruslichenko wrote:

> After commit d32932d02e18  ("x86/irq: Convert IOAPIC to use hierarchical
> irqdomain interfaces") IO-APIC is switched to hierarchical irqdomain
> implementation. Also this patch removed irq_retrigger hook for IO-APIC
> chip which seem to be wrong. Without this hook some edge-triggered irq's
> might be lost, since kernel uses it to retrigger edge irq's triggered
> while they are being handled or disabled by driver

Restoring the callbacks is the right thing to do, but there is no problem
because if the retrigger callback is empty then pending edge interrupts are
resent by software. It's just less efficient, but not a issue.

Thanks,

	tglx