Re: [PATCH v7 0/5] Add platform clock for BayTrail platforms

[Andy Shevchenko]

On Tue, 2017-01-17 at 15:57 -0600, Pierre-Louis Bossart wrote:
> These patches specifically enable the audio MCLK required by Baytrail
> CR devices. It is the remaining part of a bigger set of patches
> (already merged in Mark Brown's tree) that enable sound for Baytrail
> CR
> devices (especially Asus T100TAF) [1]. They include the clock driver
> and clock enabling in the pmc_atom code (along with moving of the
> non-architectural pmc_atom driver code into drivers/platform/x86 as
> suggested by Thomas Gleixner [2]). This move includes a new header in
> include/linux/platform_data/x86/. While there is an agreement that the
> definitions for PMC clocks are not really platform data this location
> is seen as a good-enough compromise with an agreement between Darren
> Hart and Andy Shevchenko [3]
> 
> [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2016-August/1
> 11704.html
> [2] http://mailman.alsa-project.org/pipermail/alsa-devel/2016-October/
> 113936.html
> [3] http://mailman.alsa-project.org/pipermail/alsa-devel/2016-December
> /115892.html
> 

Stephen, I see no issues with the patches. If you want to push them
through your tree, take a tag from PDx86 subsystem point of view:

Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>


> Changes from v6:
> Â- Addressed comments from Stephen Boyd, Andy Shevchenko and Vinod
> Koul
> Â- Renamed clk-byt-plt to clk-pmc-atom
> Â- Rebase to 4.10-rc3 (broonie/for-next)
> Â- Added helper functions to make error handling more compact
> Â- Removed module-related code since it's not possible/supported
> Â- Removed useless tests on remove
> Â- PMC_CLK_OFFSET move to clk-pcm-atom (more logical)
> Â- Split typo correction and makefile fix in separate patches
> Â- small fixes (spaces, defaults in switches, alphabetical order, use
> of
> clk_writel/readl and no test on write, simpler error handling, use of
> while(i--), unsigned loop variables, kernel doc fields, format-patch
> -M
> Â-C -D, use of PLATFORM_DEVID_NONE)
> 
> Changes from v5:
> Â- fix build error reported by kbuild test robot
> Â- split the clk driver code from x86 platform changes
> 
> Changes from v4:
> Â- move the pmc_atom driver from arch/x86/platform/atom to
> drivers/platform/x86
> 
> Changes from v3:
> Â- replace devm_kzalloc with devm_kcalloc
> Â- add x86 architecture maintainers
> 
> Changes from v2:
> Â- move clk platform data structures to a separate include file
> Â- store clk_hw pointer for the fixed rate clocks
> 
> Changes from v1:
> Â- register the clk device as child of pmc device
> Â- pass iomem pointer from pmc driver to clk driver to avoid using
> pmc_atom_read()/write() and use readl/writel API instead
> Â- use devm_clk_hw_register/clkdev_hw_create instead of
> clk_register/clkdev_create
> 
> Irina Tirdea (3):
> Â clk: x86: Add Atom PMC platform clocks
> Â arch/x86/platform/atom: Move pmc_atom to drivers/platform/x86
> Â platform/x86: Enable Atom PMC platform clocks
> 
> Pierre-Louis Bossart (2):
> Â clk: Make x86/ conditional on CONFIG_COMMON_CLK
> Â platform/x86: fix typo in comment
> 
> Âarch/x86/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ4 -
> Âarch/x86/platform/atom/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ1 -
> Âdrivers/acpi/acpi_lpss.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ2 +-
> Âdrivers/clk/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ2 +
> Âdrivers/clk/x86/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ1 +
> Âdrivers/clk/x86/clk-pmc-atom.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 373
> +++++++++++++++++++++
> Âdrivers/platform/x86/KconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ5 +
> Âdrivers/platform/x86/MakefileÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ1 +
> Â.../atom => drivers/platform/x86}/pmc_atom.cÂÂÂÂÂÂÂ|ÂÂ88 ++++-
> Âinclude/linux/platform_data/x86/clk-pmc-atom.hÂÂÂÂÂ|ÂÂ44 +++
> Â.../linux/platform_data/x86}/pmc_atom.hÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ2 +-
> Â11 files changed, 508 insertions(+), 15 deletions(-)
> Âcreate mode 100644 drivers/clk/x86/clk-pmc-atom.c
> Ârename {arch/x86/platform/atom => drivers/platform/x86}/pmc_atom.c
> (87%)
> Âcreate mode 100644 include/linux/platform_data/x86/clk-pmc-atom.h
> Ârename {arch/x86/include/asm =>
> include/linux/platform_data/x86}/pmc_atom.h (98%)
> 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy