Re: [PATCH v5 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info
From: Peter Zijlstra
Date: Wed Jan 18 2017 - 09:26:25 EST
On Tue, Jan 17, 2017 at 07:47:22PM +0530, Hari Bathini wrote:
> With the advert of container technologies like docker, that depend
> on namespaces for isolation, there is a need for tracing support for
> namespaces. This patch introduces new PERF_RECORD_NAMESPACES event
> for tracing based on namespaces related info.
This fails to mention the whole namespace of namespaces issue Eric
brought up. Where are we on that, and or why isn't it required?
> +/*
> + * The maximum size of the name of each namespace
> + */
> +#define NS_NAME_SIZE 8
> +
> +struct perf_ns_link_info {
> + char name[NS_NAME_SIZE];
Do we really need a name? why?
> + __u64 dev;
> + __u64 ino;
> +};
> +