Re: [PATCH 2/2] perf diff: Fix -o/--order option behavior (again)

From: Jiri Olsa
Date: Wed Jan 18 2017 - 13:37:07 EST


On Wed, Jan 18, 2017 at 02:14:57PM +0900, Namhyung Kim wrote:
> The commit 21e6d8428664 changed list_add() to
> perf_hpp__register_sort_field(). However this resulted in a behavior
> change since the field was added to the tail instead of the head. So
> the -o option is mostly ignored due to its order in the list.
>
> This patch fixes it by adding perf_hpp__prepend_sort_field().
>
> Fixes: 21e6d8428664 ("perf diff: Use perf_hpp__register_sort_field interface")
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka