Re: [PATCH v1 1/2] Documentation: mtk-quadspi: update DT bindings
From: Rob Herring
Date: Wed Jan 18 2017 - 17:09:40 EST
On Fri, Jan 13, 2017 at 03:13:26PM +0100, Boris Brezillon wrote:
> On Fri, 13 Jan 2017 15:13:28 +0800
> Guochun Mao <guochun.mao@xxxxxxxxxxxx> wrote:
>
> > Add "mediatek,mt2701-nor" for nor flash node's compatible.
> >
> > Signed-off-by: Guochun Mao <guochun.mao@xxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/mtd/mtk-quadspi.txt | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > index fb314f0..f83d31d 100644
> > --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> > @@ -1,7 +1,9 @@
> > * Serial NOR flash controller for MTK MT81xx (and similar)
> >
> > Required properties:
> > -- compatible: should be "mediatek,mt8173-nor";
> > +- compatible: should contain:
> > + "mediatek,mt2701-nor" for MT2701,
> > + "mediatek,mt8173-nor" for MT8173.
>
> Do you need to define a new compatible? If the IPs are exactly the same
> in both SoCs it shouldn't be needed.
Rather the 2701 should contain both strings in that case.
Rob