Re: [PATCH 0/6 v4] adv7511 EDID probing improvements

From: Archit Taneja
Date: Thu Jan 19 2017 - 00:24:15 EST




On 01/19/2017 04:34 AM, Laurent Pinchart wrote:
Hi John,

Thank you for the patches.

On Monday 16 Jan 2017 16:52:46 John Stultz wrote:
Wanted to re-send out v4 of this patch set, integrating some
changes suggested by Laurent, for consideration for merging for
v4.11

The first three patches are fixups that are hopefully straight
forward, integrating feedback I got from Laurant, with minimal
change from the previous versions.

The last three patches try to clean up and rework the EDID
probing code, to avoid issues seen on HiKey. I've reworked these
more significantly since v3 to address feedback from Laurent.

Thoughts and feedback would be appreciated!

For the whole series,

Tested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

Queued to drm-misc-next. Updated the commit messages for patches 5
and 6 as suggested by Laurent.

Thanks,
Archit


New in v4:
* Tweaked connector.status assignment to avoid race, as
suggested by Laurent
* Reworked the __adv7511_power_on helpers to avoid calling
regcache_sync in the EDID probe path
* Added new patch to set EDID_I2C_ADDR register before doing
EDID read.

Cc: David Airlie <airlied@xxxxxxxx>
Cc: Archit Taneja <architt@xxxxxxxxxxxxxx>
Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>
Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx

Archit Taneja (1):
drm/bridge: adv7511: Enable HPD interrupts to support hotplug and
improve monitor detection

John Stultz (5):
drm/bridge: adv7511: Use work_struct to defer hotplug handing to out
of irq context
drm/bridge: adv7511: Switch to using drm_kms_helper_hotplug_event()
drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be
reused internally
drm/bridge: adv7511: Reuse __adv7511_power_on/off() when probing EDID
drm/bridge: adv7511: Re-write the i2c address before EDID probing

drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 +
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 67
++++++++++++++++++++-------- 2 files changed, 51 insertions(+), 18
deletions(-)


--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project