Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2

From: Krzysztof Kozlowski
Date: Thu Jan 19 2017 - 02:20:15 EST


On Thu, Jan 19, 2017 at 12:47 AM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Tue, Jan 17, 2017 at 08:10:56PM +0200, Krzysztof Kozlowski wrote:
>> On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote:
>> > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>> > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote:
>> > >> This patch adds support for the TM2 touch key and led
>> > >> functionality.
>> > >>
>> > >> The driver interfaces with userspace through an input device and
>> > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be
>> > >> controlled by "/sys/class/leds/tm2-touchkey/brightness".
>> > >>
>> > >> Signed-off-by: Beomho Seo <beomho.seo@xxxxxxxxxxx>
>> > >> Signed-off-by: Jaechul Lee <jcsing.lee@xxxxxxxxxxx>
>> > >> Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>> > >> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxx>
>> > >> Reviewed-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
>> > >> Tested-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
>> > >> Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>> > >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>> > >
>> > > This looks unusual. How did Dmitry's Sob end here?
>> >
>> > I sent Jaechul a version of the patch to try out.
>>
>> Ah, makes sense then.
>
> I picked up (and folded) the binding doc and driver patches, DTS should
> go through some other tree I believe.

Yes, I will take it. I waited for driver and bindings to be accepted.

Thanks,
Krzysztof