Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms<n>
From: Jarkko Sakkinen
Date: Fri Jan 20 2017 - 08:39:23 EST
On Thu, Jan 19, 2017 at 07:19:40AM -0500, James Bottomley wrote:
> On Thu, 2017-01-19 at 12:49 +0200, Jarkko Sakkinen wrote:
> > On Wed, Jan 18, 2017 at 10:01:03AM -0500, James Bottomley wrote:
> > > On Mon, 2017-01-16 at 15:12 +0200, Jarkko Sakkinen wrote:
> > > > From: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> > > >
> > > > Currently the Resource Manager (RM) is not exposed to userspace.
> > > > Make this exposure via a separate device, which can now be
> > > > opened multiple times because each read/write transaction goes
> > > > separately via the RM.
> > > >
> > > > Concurrency is protected by the chip->tpm_mutex for each
> > > > read/write transaction separately. The TPM is cleared of all
> > > > transient objects by the time the mutex is dropped, so there
> > > > should be no interference between the kernel and userspace.
> > >
> > > There's actually a missing kfree of context_buf on the tpms_release
> > > path as well. This patch fixes it up.
> >
> > Can you send me a fresh version of the whole patch so that I can
> > include to v4 that includes also changes that I requested in my
> > recent comments + all the fixes?
>
> Sure, I think the attached is basically it
>
> James
Thank you!
/Jarkko