Re: [PATCHv4] mfd: cpcap: Add minimal support
From: Tony Lindgren
Date: Mon Jan 23 2017 - 11:31:24 EST
Hi,
* Tony Lindgren <tony@xxxxxxxxxxx> [170105 16:45]:
> Many Motorola phones like droid 4 are using a custom PMIC called CPCAP
> or 6556002. We can support it's core features quite easily with regmap_spi
> and regmap_irq.
>
> The children of cpcap, such as regulators, ADC and USB, can be just regular
> device drivers and defined in the dts file. They get probed as we call
> of_platform_populate() at the end of our probe, and then the children
> can just call dev_get_regmap(dev.parent, NULL) to get the regmap.
>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: Marcel Partap <mpartap@xxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Michael Scott <michael.scott@xxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
> Changes from v2:
>
> - Fix typos in binding documentation for #size-cells and spi-cs-high
> - Add ack from Rob
>
> Changes from v3:
>
> - Fix comments from Lee, mostly to simplify cpcap_init_irq_chip()
Lee, it's been few weeks now, do you have any more comments on
this one?
I'd like to get this out of the way for v4.11 to be able to start
sending the CPCAP regulator and USB PHY driver patches for v4.12 :)
Cheers,
Tony