Re: [PATCH] w1: omap_hdq: Free resources on error path

[Evgeniy Polyakov]

Hi Christophe

09.01.2017, 03:13, "Christophe JAILLET" <christophe.jaillet@xxxxxxxxxx>:
> In case of error returned by '_omap_hdq_reset()', free resources as done
> elsewhere in this function.
>
> This patch slighly changes the semantic of the code. It now propagates the
> error code returned by '_omap_hdq_reset()' instead of returning -EINVAL
> unconditionally.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Looks good to me.
If kernel-janitors@ will not push it upstream feel free to send to to GregKH <greg@xxxxxxxxx>
and add me to copy.

Acked-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>

> ---
> Âdrivers/w1/masters/omap_hdq.c | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index bb09de633939..fb190c259607 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -715,7 +715,7 @@ static int omap_hdq_probe(struct platform_device *pdev)
> ÂÂÂÂÂÂÂÂÂret = _omap_hdq_reset(hdq_data);
> ÂÂÂÂÂÂÂÂÂif (ret) {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂdev_dbg(&pdev->dev, "reset failed\n");
> - return -EINVAL;
> + goto err_irq;
> ÂÂÂÂÂÂÂÂÂ}
>
> ÂÂÂÂÂÂÂÂÂrev = hdq_reg_in(hdq_data, OMAP_HDQ_REVISION);
> --
> 2.9.3